Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODELIX-605 Implement adapters for the direction I -> S #318

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

mhuster23
Copy link
Contributor

No description provided.

import org.modelix.model.mpsadapters.Module

class NodeAsMPSModule private constructor(val node: INode, val sRepository: SRepository?) : SModule {
data class NodeAsMPSModule(val node: INode, val sRepository: SRepository?) : SModule {

Check warning

Code scanning / detekt

Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning

Class 'NodeAsMPSModule' with '15' functions detected. Defined threshold inside classes is set to '11'
@mhuster23 mhuster23 force-pushed the feature/mps-adapters-i-to-s branch from e388d28 to 7681e93 Compare November 10, 2023 12:42
import org.modelix.model.mpsadapters.Model

class NodeAsMPSModel private constructor(private val node: INode, private val sRepository: SRepository?) : SModel {
data class NodeAsMPSModel(val node: INode, val sRepository: SRepository?) : SModel {

Check warning

Code scanning / detekt

Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning

Class 'NodeAsMPSModel' with '25' functions detected. Defined threshold inside classes is set to '11'
@mhuster23 mhuster23 marked this pull request as ready for review November 13, 2023 16:18
@mhuster23 mhuster23 requested a review from slisson as a code owner November 13, 2023 16:18
@benedekh benedekh merged commit 896bb97 into feature/mps-sync-lib Nov 14, 2023
14 checks passed
@benedekh benedekh deleted the feature/mps-adapters-i-to-s branch November 14, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants